Forum

You are not logged in. Please note that you need to log in before posting.

Dear friends! Please note that hitAppoint will be on holidays till June 12, 2011 with a limited online access. We apologize for delayed replies. Every request will be promptly resolved on return.

#1 2010-03-13 12:07:06

tvdien
Member
Registered: 2009-02-09
Posts: 31

Several bugs

Some issues I ran into while using hitAppoint 4.0.4 with Wordpress:

- It's not possible to make a Wordpress account through hitAppoint. It tells me there's a function call to a non-existing function.
- When hitAppoint is viewed through Wordpress, it doesn't recognize the Euro sign. When viewed directly, there's no problem.
- hitAppoint becomes unusable when enabling permalinks.

Overall integration seems quite incomplete/buggy. Another thing I noticed:

- There are static references in your code to ha40_ as table prefix. I wanted ha_ and when I try to delete a location, it tells me entry ha40_something could not be deleted.

Offline

 

#2 2010-03-13 13:06:56

mattm
Member
Registered: 2009-10-31
Posts: 26

Re: Several bugs

And here is another one... email verification is busted in a couple of ways.

1. It DOES NOT WORK at all without modifying core/panels/anon/register/confirm_email/action.php

Processing tends to end abruptly in PHP when you use the exit() method...

Code:

<?php
$db =& dbWrapper::getInstance();
$conf =& ntsConf::getInstance();
$app =& ntsApplication::getInstance();

$key = $req->getParam( 'key' );
$key = trim( $key );

/* get this user restriction */
$sql =<<<EOT
SELECT
        obj_id
FROM
        {PRFX}objectmeta
WHERE
        meta_name = "_confirmKey" AND
        meta_value = "$key" AND
        obj_class = "user"
EOT;

$result = $db->runQuery( $sql );
$r = $result->fetch();
exit;
/* ok */
if( $r ){
...

Then.... if you happen to have "administrator must approve new accounts" enabled, well, the use account just stays in the "email not verified" condition, as opposed to a "email verified by Admin not approved" state.

see:

Code:

$cm->runCommand( $object, 'confirm_email' );
        if( $userAdminApproval ) {
        /* required approval by admin */
                $cm->runCommand( $object, 'require_approval' );
                ntsView::addAnnounce( M('Thank you for registering!<br>Now we kindly ask you to wait a little, we need to manually approve new acounts. We will notify you when your account gets active.'), 'ok' );

                $forwardTo = ntsLink::makeLink();
                ntsView::redirect( $forwardTo );
                exit;
                }

This thing is so buggy....

Offline

 

#3 2010-03-13 17:19:01

algis
Administrator
Registered: 2006-01-09
Posts: 1724
Website

Re: Several bugs

Hello,
thank you so much for your feedback. I've made an update (ver. 4.0.6) to fix most of these problems.

tvdien wrote:

- It's not possible to make a Wordpress account through hitAppoint. It tells me there's a function call to a non-existing function.

fixed


tvdien wrote:

- When hitAppoint is viewed through Wordpress, it doesn't recognize the Euro sign. When viewed directly, there's no problem.

sorry not fixed yet, I'll be working on it

tvdien wrote:

- hitAppoint becomes unusable when enabling permalinks.

fixed, please have a look at our demo
http://www.hitappoint.com/demo-wp/appointments/


tvdien wrote:

- There are static references in your code to ha40_ as table prefix. I wanted ha_ and when I try to delete a location, it tells me entry ha40_something could not be deleted.

fixed


tvdien wrote:

It DOES NOT WORK at all without modifying core/panels/anon/register/confirm_email/action.php

fixed


tvdien wrote:

Then.... if you happen to have "administrator must approve new accounts" enabled, well, the use account just stays in the "email not verified" condition, as opposed to a "email verified by Admin not approved" state.

fixed

Offline

 

#4 2010-03-13 23:00:24

tvdien
Member
Registered: 2009-02-09
Posts: 31

Re: Several bugs

More to come. [4.0.6]

General:
- In the Services configuration, I wanted to set the Max Advance Booking to 10 days. hitAppoint turns this into 1.42 weeks after saving. Then, when I hit Update again because of other changes, it tells me "Please enter whole numbers only".

WordPress:
- Accounts created through hitAppoint are unusable because of invalid passwords. Once the password is reset through the WordPress Admin Panel, it's OK.
- Email/account validation is useless since accounts are created and active instantly.
- Though the user base is sort-of shared (when hitAppoint is viewed directly, it doesn't know the WordPress users), there's no two-way single sign-on. Users who login through hitAppoint are logged into WordPress as well, but users who login to WordPress still have to login again when using hitAppoint.
- When hitAppoint is accessed through the module in the WordPress Admin Panel, it now requires me to login again. Earlier, at least with 4.0.1 and possibly with 4.0.4 as well, this was not required. I guess this is closely related to a second problem, more critical problem, below.
- It seems that after starting using it with WordPress, my password for the hitAppoint admin account becomes invalid. This had me reinstall hitAppoint several times now, because of below.
- Password mailings and information about newly created appointments don't reach me (the admin). Mails to WordPress users work fine.

Please consider switching to the WordPress mechanism for registration and login.

I like hitAppoint a lot and 4.0 is promising, but it might be better if you'd call it a public beta for now.

Last edited by tvdien (2010-03-13 23:20:49)

Offline

 

#5 2010-03-14 15:21:59

algis
Administrator
Registered: 2006-01-09
Posts: 1724
Website

Re: Several bugs

Hello,
thank you very much for your reports! I've just released 4.0.7

tvdien wrote:

- In the Services configuration, I wanted to set the Max Advance Booking to 10 days. hitAppoint turns this into 1.42 weeks after saving. Then, when I hit Update again because of other changes, it tells me "Please enter whole numbers only".

fixed

tvdien wrote:

- Accounts created through hitAppoint are unusable because of invalid passwords. Once the password is reset through the WordPress Admin Panel, it's OK.

fixed

Other problems with WordPress integration were because I've messed it up a bit with the previous patch update, 4.0.6 so it made hitAppoint not use the WordPress database actually. I've now fixed it. Please uninstall the hitAppoint plugin from WordPress and reinstall it again (sure with the new updated plugin file).

This will disable direct URL access to hitAppoint, access only through WordPress will be possible.

Offline

 

#6 2010-03-14 16:28:54

tvdien
Member
Registered: 2009-02-09
Posts: 31

Re: Several bugs

It seems that it only recognizes 'admin' as being admin. However, I have another user with highest WordPress privileges and to hitAppoint it's just a regular user. Please have it check the user's rights instead of username (or uid?).

Last edited by tvdien (2010-03-14 16:33:06)

Offline

 

#7 2010-03-14 16:36:39

algis
Administrator
Registered: 2006-01-09
Posts: 1724
Website

Re: Several bugs

tvdien wrote:

It seems that it only recognizes 'admin' as being admin. However, I have another user with highest WordPress privileges and to hitAppoint it's just a regular user. Please have it check the user's rights instead of username (or uid?).

agh, ok I will have a look at this. Currently on plugin installation it assigns hitAppoint admin rights to the user who is installing the plugin.

Offline

 

#8 2010-03-14 16:40:51

tvdien
Member
Registered: 2009-02-09
Posts: 31

Re: Several bugs

Thanks. For now I solved it by reinstalling the plugin as the second admin user.

Offline

 

#9 2010-03-14 16:57:11

algis
Administrator
Registered: 2006-01-09
Posts: 1724
Website

Re: Several bugs

ok, please find attached the updated plugin file. It will make all users with the "Aministrator" role to be admins in hitAppoint

Offline

 

#10 2010-03-14 16:58:46

tvdien
Member
Registered: 2009-02-09
Posts: 31

Re: Several bugs

Nice. Will it be included in the next update?

Offline

 

#11 2010-03-14 17:16:04

algis
Administrator
Registered: 2006-01-09
Posts: 1724
Website

Re: Several bugs

tvdien wrote:

Nice. Will it be included in the next update?

yes sure

Offline

 

#12 2010-03-26 12:07:37

anna007
New member
Registered: 2010-03-26
Posts: 1

Re: Several bugs

It seems that after starting using it with WordPress, my password for the hitAppoint admin account becomes invalid. This had me reinstall hitAppoint several times now, because of below.
- Password mailings and information about newly created appointments don't reach me (the admin). Mails to WordPress users work fine.
..................

Offline

 

Board footer

Powered by PunBB
© Copyright 2002–2005 Rickard Andersson